Preserve original variables when using a loop #59417
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The fix in #59024 resulted in any task variables defined that were used in the connection/shell/become options would no longer be defined in future loop iterations. This is an alternative way to solve #58876 by taking a copy of the variables before they are modified by
self._play_context.update_vars(variables)
ensuring future loop iterations will still honour the task directive value.This could be a potential memory issue so will need others to chime in.
Fixes #59414
ISSUE TYPE
COMPONENT NAME
task_executor